-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls/internal: convert variadic arguments from string to []byte/[]rune #512
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
…rune gopls will correctly convert a string argument to a []byte/[]rune argument, however it will not check if the the target is also variadic.
This PR (HEAD: 8e231bc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608695. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Hamza Ali: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Jorropo: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-27T13:05:00Z","revision":"39965ac80f601acff65577f8738ce99f223f8f20"} Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
Message from Robert Findley: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608695. |
gopls will correctly convert a string argument to a []byte/[]rune argument,
however it will not check if the the target is also variadic.