Skip to content

Commit

Permalink
src/debugAdapter: disable stackTrace error pop-ups
Browse files Browse the repository at this point in the history
The errors already show up in the UI under CALL STACK, so the pop-ups just get in the way.

Updates #179

Change-Id: I3ba1e7c65c363e00d16b0962a83b0f873bfd0e60
GitHub-Last-Rev: b3a2611
GitHub-Pull-Request: #1236
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/293530
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Polina Sokolova <polina@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
  • Loading branch information
polinasok committed Feb 23, 2021
1 parent 8272510 commit 54602c5
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/debugAdapter/goDebug.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1452,9 +1452,14 @@ export class GoDebugSession extends LoggingDebugSession {
async (err, out) => {
if (err) {
this.logDelveError(err, 'Failed to produce stacktrace');
return this.sendErrorResponse(response, 2004, 'Unable to produce stack trace: "{e}"', {
e: err.toString()
});
return this.sendErrorResponse(
response,
2004,
'Unable to produce stack trace: "{e}"',
{ e: err.toString() },
// Disable showUser pop-up since errors already show up under the CALL STACK pane
null
);
}
const locations = this.delve.isApiV1 ? <DebugLocation[]>out : (<StacktraceOut>out).Locations;
log('locations', locations);
Expand Down

0 comments on commit 54602c5

Please # to comment.