Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

debug: find a way to use dlv-dap with debug test codelens #1293

Closed
hyangah opened this issue Mar 11, 2021 · 3 comments
Closed

debug: find a way to use dlv-dap with debug test codelens #1293

hyangah opened this issue Mar 11, 2021 · 3 comments
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 11, 2021

Due to the issue #855
we currently don't have an easy way to run debugging using dlv-dap.
Either we need to fix the issue, or take advantage of "go.delveConfig" setting.

cc @polinasok @suzmue

@hyangah hyangah changed the title debug: find a way to use dlv-dap with debug test codelense debug: find a way to use dlv-dap with debug test codelens Mar 15, 2021
@hyangah hyangah added Debug Issues related to the debugging functionality of the extension. DlvDAP labels Mar 25, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/306969 mentions this issue: src/goTest.ts: allow users to select dlv-dap in codelenses

@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@hyangah hyangah modified the milestones: Untriaged, v0.24.1 Apr 13, 2021
@hyangah
Copy link
Contributor Author

hyangah commented Apr 13, 2021

@suzmue I think we need documentation update.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/309749 mentions this issue: docs/dlv-dap.md: include go.delveConfig setting for debugAdapter

gopherbot pushed a commit that referenced this issue Apr 13, 2021
With the addition of the "debugAdapter" attribute to the
go.delveConfig setting, users can easily select dlv-dap for
all debug sessions including codelenses.

Updates #1293

Change-Id: Icc4cedf3e684418069911728cfb66efec6662167
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/309749
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@golang golang locked and limited conversation to collaborators Apr 13, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants