Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ci: test with go 1.18 prereleases #1950

Closed
hyangah opened this issue Dec 16, 2021 · 2 comments
Closed

ci: test with go 1.18 prereleases #1950

hyangah opened this issue Dec 16, 2021 · 2 comments
Labels
FrozenDueToAge
Milestone
vscode-go/backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 16, 2021

No description provided.

@gopherbot gopherbot added this to the Untriaged milestone Dec 16, 2021
@hyangah hyangah modified the milestones: Untriaged, On Deck Dec 16, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/374055 mentions this issue: workflow: enable tests with go1.18beta1

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/411104 mentions this issue: test/integration: reenable staticcheck and fix "Error checking" test

gopherbot pushed a commit that referenced this issue Jun 9, 2022
@hyangah
test/integration: reenable staticcheck and fix "Error checking" test
8bc0703 
Staticcheck has been supporting go1.18 for a while,
so reenable the skipped test.

https://go-review.googlesource.com/c/vscode-go/+/405551 rearranged
how diagnostics collection was passed. We need to pass them as goCtx.

Updates #1950
Fixes #2282

Change-Id: I9147e452bcfe61c8a5a260c0cca246dcc2375f0e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/411104
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Jun 8, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
vscode-go/backlog
Development

No branches or pull requests
2 participants
@hyangah @gopherbot