Skip to content

Go: Fill struct is missing. #3101

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ekkoful opened this issue Dec 25, 2023 · 4 comments
Closed

Go: Fill struct is missing. #3101

ekkoful opened this issue Dec 25, 2023 · 4 comments
Milestone
Untriaged

Comments

@ekkoful
Copy link

ekkoful commented Dec 25, 2023

Type: Bug

The Go: fill struct is missing when i use mac os remote ssh a ubuntu server.

image

Extension version: 0.40.1
VS Code version: Code 1.85.1 (Universal) (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:06.308Z)
OS version: Darwin arm64 21.6.0
Modes:
Remote OS version: Linux x64 5.4.0-117-generic

System Info
Item Value
CPUs Apple M1 (8 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 4, 3, 2
Memory (System) 8.00GB (0.11GB free)
Process Argv --crash-reporter-id ff734aa8-5d43-4482-a6d6-25efb50f9d48
Screen Reader no
VM 0%
Item Value
Remote SSH: devbox
OS Linux x64 5.4.0-117-generic
CPUs Intel(R) Xeon(R) KVM CPU @ 2.50GHz (12 x 2499)
Memory (System) 45.09GB (24.16GB free)
VM 24%
A/B Experiments 
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30899288
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
f6dab269:30613381
showlangstatbar:30737416
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
accentitlementst:30887150
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
dsvsc019cf:30917260
cp7184c:30925681
@ekkoful ekkoful changed the title Go: fill struct is missing. Go: Fill struct is missing. Dec 25, 2023
@gopherbot gopherbot added this to the Untriaged milestone Dec 25, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/552735 mentions this issue: gopls/internal/lsp/source: simplify SuggestedFix plumbing

@hyangah
Copy link
Contributor

hyangah commented Dec 26, 2023

"Go: Fill struct" command was retired #2107

Sorry for interrupting your workflow. We considered to leave Go: Fill struct but concluded this doesn't add much value any more. Can you try Cmd + . default binding?

#2107 (comment)

@ekkoful
Copy link
Author

ekkoful commented Dec 27, 2023

OK，Thank you ! @hyangah

@ekkoful ekkoful closed this as completed Dec 27, 2023
gopherbot pushed a commit to golang/tools that referenced this issue Dec 31, 2023
@adonovan @gopherbot
gopls/internal/lsp/source: simplify SuggestedFix plumbing
1f94566 
This change simplifies the interface to "suggested fix"
functions so that the general case and single-file case
are more alike.

The argument types have changed thus:
(file.Handle, protocol.Range) ->
 (pkg *cache.Package, pgf *parsego.File, start, end token.Pos)
and the results thus:
 []protocol.TextDocumentEdit -> (*token.FileSet, *analysis.SuggestedFix)

The extra FileSet result is needed because Pos values in
the SuggestedFix are not necessarily mapped by pkg.FileSet().

The logic of the singleFile wrapper moved into ApplyFix,
so it is now trivial, but unfortunately we can't get rid
of it yet because it breaks an import cycle from the
analyzer packages to cache. We first need to stop using
analyzers for quick fixes.

Also:
- rename suggestedFixFunc -> Fixer
- add various missing comments.
- merge the two parts of stubMethodsFixer.

(This was preparatory work while trying to understand
the associated issue.)

Updates golang/vscode-go#3101

Change-Id: I4602f7e22730a9037707e13f08b52d5cb7c714d6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/552735
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
@GAZ082
Copy link

GAZ082 commented Jun 9, 2024

Booo

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Untriaged
Development

No branches or pull requests
4 participants
@GAZ082 @hyangah @gopherbot @ekkoful