Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gocode: installation of gocode fails #355

Closed
hyangah opened this issue Jul 15, 2020 · 2 comments
Closed

gocode: installation of gocode fails #355

hyangah opened this issue Jul 15, 2020 · 2 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 15, 2020

From the slack https://gophers.slack.com/archives/C2B4L99RS/p1594808544075000

This was after getting the prompt from the Go extension to update the tools after detecting a new Go version. All other items were updated successfully, but not gocode. I then opted to try and install it separately via "Go: Install/Update Tools" VSCode option.

Ubuntu system:
Installing 1 tool at /home/adam/go/bin in module mode.
  gocode
1 tools failed to install.
gocode: Failed to close gocode process: Error: Command failed: /home/adam/go/bin/gocode close
2020/07/15 05:18:08 dial unix /tmp/gocode-daemon.adam: connect: no such file or directory
Windows system:
Tools environment: GOPATH=C:\Users\atc0005\go
Installing 1 tool at C:\Users\atc0005\go\bin in module mode.
  gocode
1 tools failed to install.
gocode: Failed to close gocode process: Error: Command failed: C:\Users\atc0005\go\bin\gocode.exe close
2020/07/15 05:10:15 dial tcp 127.0.0.1:37373: connectex: No connection could be made because the target machine actively refused it.

The corresponding logic is https://github.com/golang/vscode-go/blob/master/src/goTools.ts#L185-L200
@stamblerre I am not familiar with gocode's closing logic. Is it necessary? And shouldn't the extension avoid this if gocode is not in use?

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/242780 mentions this issue: goTools: don't fail gocode installation if gocode is not already running

@hyangah hyangah added this to the v0.16.0 milestone Jul 15, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/243898 mentions this issue: [release] goTools: don't fail gocode installation if gocode is not already running

gopherbot pushed a commit that referenced this issue Jul 21, 2020
…ready running

Fixes #355
Fixes #362

Change-Id: Ifdf229ce52a6a4b1a2e4f0a28ac5596405ff4c56
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/242780
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
(cherry picked from commit db1d1b3)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/243898
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@hyangah hyangah modified the milestones: v0.16.0, v0.15.2 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants