installation: version check for other tools #487
Milestone
Comments
|
Change https://golang.org/cl/349752 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Sep 14, 2021
The existing tool version checks in suggestUpdates simply compare the go version & GOROOT/GOPATH used with the tool last time. That is a hack added when there was no good way to check tool's exact versions and users organize compatible tools using GOPATH. Now many of recent tools (e.g. gopls) do not depend on hardcoded GOROOT or the go version used while compiling the tools. It's still desirable to compile tools with the latest version of go but the go version does not have to match exactly with the go version used to compile the tools. For example, tools compiled with go1.16 can be used to work with go1.16.1 or go1.15. Now Go is released frequently, and the extension allows users to switch between different go versions more easily, this incorrect popup is often annoying and confuses users, than helping users stay up-to-date with latest tools. Remove this incorrect heuristic for now. Updates #487 Fixes #1698 Change-Id: I7a7c6a0d654ae080ea2bd221a366230ebb98bb7e Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349752 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
|
Change https://golang.org/cl/349953 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Sep 14, 2021
The existing tool version checks in suggestUpdates simply compare the go version & GOROOT/GOPATH used with the tool last time. That is a hack added when there was no good way to check tool's exact versions and users organize compatible tools using GOPATH. Now many of recent tools (e.g. gopls) do not depend on hardcoded GOROOT or the go version used while compiling the tools. It's still desirable to compile tools with the latest version of go but the go version does not have to match exactly with the go version used to compile the tools. For example, tools compiled with go1.16 can be used to work with go1.16.1 or go1.15. Now Go is released frequently, and the extension allows users to switch between different go versions more easily, this incorrect popup is often annoying and confuses users, than helping users stay up-to-date with latest tools. Remove this incorrect heuristic for now. Updates #487 Fixes #1698 Change-Id: I7a7c6a0d654ae080ea2bd221a366230ebb98bb7e Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349752 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> (cherry picked from commit 23a2db0) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349953 Reviewed-by: Suzy Mueller <suzmue@golang.org> Trust: Suzy Mueller <suzmue@golang.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Currently only gopls is doing the version check by querying proxy.golang.org.
We can apply the same approach to other tools.
We need to ensure important tools are installed in modules mode.
Some tools have
versioncommands (e.g. gopls). Otherwise, utilizego version -mcommand.The text was updated successfully, but these errors were encountered: