Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

package.json: settings.json diagnostics indicates goimports in go.alternateTools isn't allowed #526

Closed
hyangah opened this issue Aug 14, 2020 · 2 comments
Closed

package.json: settings.json diagnostics indicates goimports in go.alternateTools isn't allowed #526

hyangah opened this issue Aug 14, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
v0.16.2

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 14, 2020

This is not true.
image
I guess the culprit is https://github.com/golang/vscode-go/blob/master/package.json#L1930
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 14, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/248619 mentions this issue: package.json: allow additional properties for alternateTools

@hyangah hyangah added this to the v0.17.0 milestone Aug 15, 2020
@hyangah hyangah mentioned this issue Aug 31, 2020
Closed
@hyangah hyangah modified the milestones: v0.17.0, v0.16.2 Sep 1, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/252120 mentions this issue: [release] package.json: allow additional properties for alternateTools

gopherbot pushed a commit that referenced this issue Sep 1, 2020
@hyangah
[release] package.json: allow additional properties for alternateTools
903ccc7 
In #284, we started
to use additionalProperties to support vscode's new setting UI
feature available for object type settings if the settings
accept only predefined properties.

 "go.alternateTools" can accept more tool names than those
specified in package.json. So, correct its additionalProperties
value.

Fixes #526

Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619
Reviewed-by: Suzy Mueller <suzmue@golang.org>
(cherry picked from commit e1603dd)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/252120
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Sep 1, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
v0.16.2
Development

No branches or pull requests
2 participants
@hyangah @gopherbot