Skip to content

package.json: update remote attach references to reflect dlv-dap support #1925

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

polinasok
Copy link
Contributor

Updates #1861

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 3, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: 4f74dad) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/368936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 9195536) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/368936 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a046feee-f805-489c-9bdf-706e74e54291


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/a046feee-f805-489c-9bdf-706e74e54291


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 6, 2021
Updates #1861

Change-Id: Ic429043aee93bcb0be34de2be861124bf548cde5
GitHub-Last-Rev: 9195536
GitHub-Pull-Request: #1925
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/368936
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Polina Sokolova <polina@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link
Collaborator

Message from Polina Sokolova:

Patch Set 2: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/368936.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/368936 has been merged.

@gopherbot gopherbot closed this Dec 6, 2021
@polinasok polinasok deleted the remotePackageJson branch December 28, 2021 20:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants