src/goDebugFactory: improve start-up and session fail messages for remote dlv-dap #1945
Conversation
polinasok
force-pushed
the
remoteWarning
branch
from
d0857d4 to
6b1de51
Compare
hyangah
added
cla: yes
|
This PR (HEAD: 6b1de51) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/371974 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371974. |
polinasok
changed the title
|
With successful connection with dlv v1.7.3: With unsuccessful connection with older dlv or no dlv: |
|
This PR (HEAD: a731107) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/371974 to see it. Tip: You can toggle comments from me using the |
|
Message from Polina Sokolova: Patch Set 3: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371974. |
|
Message from Polina Sokolova: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/371974. |
|
Message from Hyang-Ah Hana Kim: Patch Set 4: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/371974. |
…mote dlv-dap Updates #1861 The informational message alerting the user that they are using new remote dlv-dap mode will always pop-up when remote attach session is started. The user has the option to disable it with "Do not show again". If connection/attach fail, an additional pop-up will occur to high-light that this is dlv-dap mode that requires newer versions of dlv. Change-Id: If56a9481323c57c11a740d1b61df20631c796bd0 GitHub-Last-Rev: a731107 GitHub-Pull-Request: #1945 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/371974 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Polina Sokolova <polina@google.com>
|
This PR is being closed because golang.org/cl/371974 has been merged. |
Updates #1861
The informational message alerting the user that they are using new remote dlv-dap mode will always pop-up when remote attach session is started. The user has the option to disable it with "Do not show again". If connection/attach fail, an additional pop-up will occur to high-light that this is dlv-dap mode that requires newer versions of dlv.