Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tie the action default version to golangci/golangci-lint's release - release both when the underlying changes #1091

Open
2 tasks done
ldemailly opened this issue Aug 23, 2024 · 0 comments
Labels
wontfix This will not be worked on

Comments

@ldemailly
Copy link

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

CI result changes mid PRs / at random time because the default is "latest"

Yet I don't want to hardcode a version and get stuck in the past, I would like dependabot to tell me there is a new version of the action which would match a new version of golangci/golangci-lint

Describe the solution you'd like.

Tag/release a new action each time a new golangci/golangci-lint release is made

Add/link the release notes of golangci/golangci-lint

Describe alternatives you've considered.

Using go install/go.mod/tools but that also doesn't work because go install version of golangci/golangci-lint isn't same as binary releases (replaces...)

Additional context.

Thanks for your consideration!

ldemailly added a commit to fortio/workflows that referenced this issue Aug 23, 2024
@ldez ldez added the wontfix This will not be worked on label Aug 23, 2024
ldemailly added a commit to fortio/workflows that referenced this issue Aug 23, 2024
* ping golanglint-ci version

pending golangci/golangci-lint-action#1091

* also disable exportloopref to avoid warning about it
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants