Skip to content

v1.2.2 was broke if using working-directory #39

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
cc4i opened this issue Jul 14, 2020 · 4 comments · Fixed by #40
Closed

v1.2.2 was broke if using working-directory #39

cc4i opened this issue Jul 14, 2020 · 4 comments · Fixed by #40
Assignees
Labels
bug Something isn't working

Comments

@cc4i
Copy link

cc4i commented Jul 14, 2020

For example:
lint-go:
name: Lint Go code
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Run golangci-lint for dice
uses: golangci/golangci-lint-action@v1
with:
version: v1.26
working-directory: ./dice
args: --timeout 5m

Output err:
Running [/home/runner/golangci-lint-1.26.0-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=./dice --timeout 5m] in [/home/runner/work/aws-solutions-assembler/aws-solutions-assembler/dice] ...
level=error msg="Can't get config for command line: can't parse args: unknown flag: --path-prefix"

@sayboras
Copy link
Member

@cc4i thanks for reporting this issue.

Do you mind testing again with v1.28 ? Seems like v1.2.2 supports 1.28+ only, versioning strategy might need to be revised.

@sayboras sayboras added the bug Something isn't working label Jul 14, 2020
@SVilgelm
Copy link
Member

Yeah, I think we need to change the minimum version and create one more release (1.2.3)

@SVilgelm SVilgelm self-assigned this Jul 14, 2020
@SVilgelm
Copy link
Member

We forgot to change the minimum version of golangci-lint that can be used, I prepared a patch with these changes and updated the README.md

@SVilgelm SVilgelm mentioned this issue Jul 14, 2020
@SVilgelm SVilgelm pinned this issue Jul 14, 2020
@SVilgelm
Copy link
Member

SVilgelm commented Jul 14, 2020

Here is the plans to fix it:

  • merging Prepare v2.0.0 #40
  • releasing v2.0.0
  • deprecating v1.2.2 (remove the tag)
  • retagging v1 to v1.2.1

@SVilgelm SVilgelm unpinned this issue Jul 23, 2020
kalensk added a commit to kalensk/gpupgrade that referenced this issue Nov 18, 2020
v1.2.2 is deprecated due to forgetting to change the minimum version of
golangci-lint to v1.28.3. See issue:
golangci/golangci-lint-action#39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants