Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

typecheck: improve error stack parsing. #1886

Merged
merged 2 commits into from
Apr 4, 2021
Merged

typecheck: improve error stack parsing. #1886

merged 2 commits into from
Apr 4, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 3, 2021

Fixes #1885

@ldez ldez added the bug Something isn't working label Apr 3, 2021
@ldez ldez force-pushed the feat/improve-stack-crusher branch 4 times, most recently from c83ef20 to c2df918 Compare April 3, 2021 21:33
@ldez ldez marked this pull request as draft April 3, 2021 21:38
@ldez ldez force-pushed the feat/improve-stack-crusher branch from d572ece to c2c33dc Compare April 3, 2021 21:40
@ldez ldez force-pushed the feat/improve-stack-crusher branch 6 times, most recently from f5b35c7 to 63ccffa Compare April 4, 2021 01:04
@ldez ldez marked this pull request as ready for review April 4, 2021 01:04
bombsimon
bombsimon approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the feat/improve-stack-crusher branch from 63ccffa to 19c2e2b Compare April 4, 2021 08:44
@ldez ldez merged commit a833cc1 into golangci:master Apr 4, 2021
@ldez ldez deleted the feat/improve-stack-crusher branch April 4, 2021 08:55
@ldez ldez added this to the v1.40 milestone Mar 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.40
Development

Successfully merging this pull request may close these issues.

Govet and staticcheck report a warning and an error instead of the problem in code
2 participants
@ldez @bombsimon