Skip to content

dev: minor clean up #4492

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2024
Merged

dev: minor clean up #4492

merged 4 commits into from
Mar 12, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 12, 2024

Related to @Antonboom reviews.

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Mar 12, 2024
@ldez ldez added this to the next milestone Mar 12, 2024
@ldez ldez requested review from alexandear and Antonboom March 12, 2024 18:47
This was referenced Mar 12, 2024
Merged
Merged
@ldez ldez force-pushed the feat/minor-cleanup branch from 2e21cf7 to 06f7d1a Compare March 12, 2024 19:04
@ldez ldez requested a review from bombsimon March 12, 2024 19:20
@ldez ldez merged commit 0554536 into golangci:master Mar 12, 2024
12 checks passed
@ldez ldez deleted the feat/minor-cleanup branch March 12, 2024 22:38
Antonboom
Antonboom reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@Antonboom Antonboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u

@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Antonboom Antonboom Antonboom left review comments

@alexandear alexandear alexandear approved these changes

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.
4 participants
@ldez @alexandear @bombsimon @Antonboom