Skip to content

dev: reformat code with gofumpt #4500

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

dev: reformat code with gofumpt #4500

merged 2 commits into from
Mar 13, 2024

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Mar 13, 2024 •
edited
Loading

The PR reformats code with gofumpt linter.

@alexandear alexandear mentioned this pull request Mar 13, 2024
Merged
@alexandear alexandear added the topic: cleanup Related to code, process, or doc cleanup label Mar 13, 2024
@ldez ldez self-requested a review March 13, 2024 18:27
@ldez ldez added the blocked Need's direct action from maintainer label Mar 13, 2024
@ldez
Copy link
Member

ldez commented Mar 13, 2024

can you rebase you PR?

@ldez ldez added feedback required Requires additional feedback and removed blocked Need's direct action from maintainer labels Mar 13, 2024
@alexandear alexandear force-pushed the chore/enable-gofumpt branch from e02fdb5 to 50030a4 Compare March 13, 2024 21:00
@alexandear
Copy link
Member Author

rebased

@ldez
Copy link
Member

ldez commented Mar 13, 2024 •
edited
Loading

Because this configuration is used as a regression test I prefer to keep go fmt.
It allows us to follow the Go modification.

We can't keep the changes but not add gofumpt.

@ldez ldez added blocked Need's direct action from maintainer and removed feedback required Requires additional feedback labels Mar 13, 2024
@alexandear alexandear changed the title dev: use gofumpt instead of gofmt dev: reformat code with gofumpt Mar 13, 2024
@alexandear
Copy link
Member Author

Reverted changes for .golangci.yml, and changed accordingly PR's title and description.

@ldez ldez removed the blocked Need's direct action from maintainer label Mar 13, 2024
@ldez ldez added this to the next milestone Mar 13, 2024
ldez
ldez approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit ea82373 into golangci:master Mar 13, 2024
12 checks passed
@alexandear alexandear deleted the chore/enable-gofumpt branch March 14, 2024 07:21
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez