Skip to content

dev: clean up #4502

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2024
Merged

dev: clean up #4502

merged 2 commits into from
Mar 14, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 13, 2024

Review from #4457 by @Antonboom

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Mar 13, 2024
@ldez ldez added this to the next milestone Mar 13, 2024
@ldez ldez requested a review from alexandear March 13, 2024 20:27
@ldez ldez force-pushed the fix/late-review branch from 622d5bb to b103860 Compare March 13, 2024 20:38
alexandear
alexandear approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 7489d44 into golangci:master Mar 14, 2024
12 checks passed
@ldez ldez deleted the fix/late-review branch March 14, 2024 17:25
@Antonboom
Copy link
Contributor

❤️

@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
@ldez ldez mentioned this pull request Mar 19, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexandear alexandear

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @Antonboom @alexandear