Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: check that Go version use to build is greater or equals to the Go version of the project #4938

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 21, 2024

To avoid issues related to the new version of Go, I would add a check to ensure that the Go version used to build is compatible with the Go version used by a project.

Related to all the issues after each new release of Go.
A small extract of the related issues: #4909, #4908, #4932, #4933, etc.

Output example:

$ ./golangci-lint run
Error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23)
Failed executing command with error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23)

@ldez ldez added the enhancement New feature or improvement label Aug 21, 2024
@ldez ldez added this to the next milestone Aug 21, 2024
@ldez ldez requested a review from bombsimon August 21, 2024 23:36
@ldez ldez force-pushed the fix/check-go branch 2 times, most recently from 5c54f90 to 76b7da7 Compare August 21, 2024 23:48
@ldez ldez requested a review from alexandear August 22, 2024 15:53
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ldez ldez merged commit f0c1904 into golangci:master Aug 22, 2024
16 checks passed
@ldez ldez deleted the fix/check-go branch August 22, 2024 21:28
@ldez ldez modified the milestones: next, v1.60 Aug 22, 2024
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
… (hetznercloud/fleeting-plugin-hetzner!112)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [golangci/golangci-lint](https://github.com/golangci/golangci-lint) | repository | patch | `v1.60.2` -> `v1.60.3` |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>golangci/golangci-lint (golangci/golangci-lint)</summary>

### [`v1.60.3`](https://github.com/golangci/golangci-lint/releases/tag/v1.60.3)

[Compare Source](golangci/golangci-lint@v1.60.2...v1.60.3)

`golangci-lint` is a free and open-source project built by volunteers.

If you value it, consider supporting us, the [maintainers](https://opencollective.com/golangci-lint) and [linter authors](https://golangci-lint.run/product/thanks/).

We appreciate it! ❤️

For key updates, see the [changelog](https://golangci-lint.run/product/changelog/#&#8203;1603).

#### Changelog

-   [`c2e095c`](golangci/golangci-lint@c2e095c) build(deps): bump github.com/securego/gosec/v2 from [`81cda2f`](golangci/golangci-lint@81cda2f91fbe) to [`ab3f6c1`](golangci/golangci-lint@ab3f6c1c83a0) ([#&#8203;4943](golangci/golangci-lint#4943))
-   [`f0c1904`](golangci/golangci-lint@f0c1904) feat: check that Go version use to build is greater or equals to the Go version of the project ([#&#8203;4938](golangci/golangci-lint#4938))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41MS4wIiwidXBkYXRlZEluVmVyIjoiMzguNTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
uudashr pushed a commit to uudashr/golangci-lint that referenced this pull request Sep 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants