Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): bump github.com/securego/gosec/v2 from 2.21.0 to 2.21.1 #4982

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2024

Bumps github.com/securego/gosec/v2 from 2.21.0 to 2.21.1.

Release notes

Sourced from github.com/securego/gosec/v2's releases.

v2.21.1

Changelog

  • 0ce4453ddd8cca1291d2056cf903b545baad95a0 Rollback the SARIF version to 2.1 since github doesn't support 2.2 (#1210)
  • ea26e8431f53a5d229b1c07ffe3529008a01c25e Update gosec in github action to v2.21.0 (#1208)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/securego/gosec/v2](https://github.com/securego/gosec) from 2.21.0 to 2.21.1.
- [Release notes](https://github.com/securego/gosec/releases)
- [Changelog](https://github.com/securego/gosec/blob/master/.goreleaser.yml)
- [Commits](securego/gosec@v2.21.0...v2.21.1)

---
updated-dependencies:
- dependency-name: github.com/securego/gosec/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Sep 4, 2024
@ldez ldez added the linter: update version Update version of linter label Sep 4, 2024
@ldez ldez added this to the next milestone Sep 4, 2024
@ldez ldez self-requested a review September 4, 2024 15:06
@ldez ldez merged commit dd069d5 into master Sep 4, 2024
16 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/securego/gosec/v2-2.21.1 branch September 4, 2024 15:27
@ccoVeille
Copy link
Contributor

For anyone interested, gosec rules G115 has been improved, but there are still some false-positive to be fixed

@czechbol
Copy link

czechbol commented Sep 4, 2024

It turns out it's a pretty complex problem that I totally didn't anticipate.

I spent 2 weeks on at least resolving the most glaring issues with the original implementation that simply flagged any conversion from a larger int to a smaller one.

@ldez
Copy link
Member

ldez commented Sep 4, 2024

Now G115 has been spread with its false positives, we cannot provide a solution inside golangci-lint.

Users have either disabled G115 or ignored some of the reports, so bad things are done 😢.

So now, we will just wait for the next release of gosec, but I think this rule will always have false positives.

@ccoVeille
Copy link
Contributor

ccoVeille commented Sep 4, 2024

@czechbol and thanks for doing it, this rule addition was promising, but indeed the consequences were unexpected.

So thanks again.

@ldez ldez modified the milestones: next, v1.61 Sep 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants