Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: improve forbidigo pattern examples for built-in functions #5116

Merged

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Nov 8, 2024

The pattern ^print.*$ also matches printer, but it's expected to match only print or println built-in functions.

@alexandear alexandear force-pushed the docs/improve-forbid-for-builtin branch 2 times, most recently from 336c621 to a24ecae Compare November 8, 2024 12:18
@alexandear alexandear changed the title docs: fix forbid pattern for builtin functions docs: fix forbid pattern for built-in functions Nov 8, 2024
@alexandear alexandear force-pushed the docs/improve-forbid-for-builtin branch from a24ecae to 38e2db6 Compare November 8, 2024 12:19
@alexandear alexandear force-pushed the docs/improve-forbid-for-builtin branch from 38e2db6 to 0a58713 Compare November 8, 2024 12:21
@ldez ldez changed the title docs: fix forbid pattern for built-in functions docs: improce forbid pattern examples for built-in functions Nov 8, 2024
@ldez ldez changed the title docs: improce forbid pattern examples for built-in functions docs: improve forbidigo pattern examples for built-in functions Nov 8, 2024
@ldez ldez added the enhancement New feature or improvement label Nov 8, 2024
@ldez ldez added this to the next milestone Nov 8, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit b46ad10 into golangci:master Nov 8, 2024
15 checks passed
@alexandear alexandear deleted the docs/improve-forbid-for-builtin branch November 8, 2024 12:54
@ccoVeille
Copy link
Contributor

Thavks for this one @alexandear

I also had the issue age ago, with legitimate printWhatever legitimate package scoped functions

I forgot to open a PR to report it

Also, thank you for providing a link to documentation about these functions.

@ldez ldez modified the milestones: next, v1.62 Nov 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants