Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

loggercheck: add missing slog option #5155

Merged
merged 1 commit into from
Nov 25, 2024
Merged

loggercheck: add missing slog option #5155

merged 1 commit into from
Nov 25, 2024

Conversation

alexandear
Copy link
Member

Support for log/slog was added in timonwong/loggercheck#72. And integrated to golangci-lint in #5094

@ldez ldez added linter: update Update the linter implementation inside golangci-lint bug Something isn't working labels Nov 25, 2024
@ldez ldez added this to the next milestone Nov 25, 2024
ldez
ldez approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 33c140e into golangci:master Nov 25, 2024
15 checks passed
@alexandear alexandear deleted the loggercheck-missing-slog-opt branch November 25, 2024 14:44
@ldez ldez mentioned this pull request Nov 28, 2024
Merged
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez