Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build(deps): bump santhosh-tekuri/jsonschema/v5 to v6 #5171

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

alexandear
Copy link
Member

santhosh-tekuri/jsonschema@v6.0.0-beta1...v6.0.1

It's impossible to compare v5 and v6 on GitHub because "There isn’t anything to compare. v5.3.1 and v6.0.1 are entirely different commit histories".

Used the following commands for tests:

$ go run ./cmd/golangci-lint config verify
$ go run ./cmd/golangci-lint config verify --schema jsonschema/golangci.jsonschema.json
$ echo $?
0
$ go run ./cmd/golangci-lint config verify -c .golangci.next.reference.yml --schema ./jsonschema/golangci.next.jsonschema.json

jsonschema: "linters-settings.goheader" does not validate with "/properties/linters-settings/properties/goheader/oneOf": "oneOf failed, subschemas 0, 1 matched"
jsonschema: "linters-settings.custom.example" does not validate with "/properties/linters-settings/properties/custom/patternProperties/%5E.%2A$/oneOf": "oneOf failed, subschemas 0, 1 matched"
Failed executing command with error: the configuration contains invalid elements
exit status 3
$ go run ./cmd/golangci-lint config verify --schema https://raw.githubusercontent.com/golangci/golangci-lint/master/jsonschema/golangci.next.jsonschema.json
$ echo $?
0
$ go run ./cmd/golangci-lint config verify
Failed executing command with error: [.golangci.yml] validate: compile schema: failing loading "https://raw.githubusercontent.com/golangci/golangci-lint/unknown/jsonschema/golangci.next.jsonschema.json": https://raw.githubusercontent.com/golangci/golangci-lint/unknown/jsonschema/golangci.next.jsonschema.json returned status code 404
exit status 3

This update is done by hand because dependabot is not able to handle major version.

@ldez ldez changed the title dev: bump santhosh-tekuri/jsonschema/v5 to v6 build(deps): bump santhosh-tekuri/jsonschema/v5 to v6 Nov 29, 2024
@ldez ldez self-requested a review November 29, 2024 17:23
@ldez ldez added dependencies Relates to an upstream dependency go Pull requests that update Go code area: JSON schema labels Nov 29, 2024
@ldez ldez added this to the next milestone Nov 29, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit bab25b4 into golangci:master Nov 29, 2024
15 checks passed
@alexandear alexandear deleted the dev-jsonschema-v6 branch November 29, 2024 22:01
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area: JSON schema dependencies Relates to an upstream dependency go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants