Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

gosec: handling of global nosec option when it is false #5228

Merged
merged 1 commit into from
Dec 15, 2024
Merged

gosec: handling of global nosec option when it is false #5228

merged 1 commit into from
Dec 15, 2024

Conversation

alexandear
Copy link
Member

Fixes #5227

@ldez ldez added bug Something isn't working linter: update Update the linter implementation inside golangci-lint labels Dec 14, 2024
@ldez ldez self-requested a review December 14, 2024 17:14
@ldez ldez added this to the next milestone Dec 15, 2024
ldez
ldez approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 87ea9ef into golangci:master Dec 15, 2024
15 checks passed
@alexandear alexandear deleted the gosec-fix-nosec-false branch December 15, 2024 20:25
@ldez ldez modified the milestones: next, v1.63 Jan 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
bug Something isn't working linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.63
Development

Successfully merging this pull request may close these issues.

gosec: global nosec option is not honored when set to false
2 participants
@alexandear @ldez