Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cis/baremetal] Move subnet module to network subpackage #13

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

dollierp
Copy link
Contributor

@dollierp dollierp commented Jul 8, 2022

This move does not keep backward compatibility:

  • import stanzas need to be updated from cis.baremetal to cis.network
  • get_subnets() function now returns a dict instead of a list to be
    consistent with cis.baremetal.harware.get_baremetals() function.

This move does not keep backward compatibility:
- import stanzas need to be updated from cis.baremetal to cis.network
- get_subnets() function now returns a dict instead of a list to be
  consistent with cis.baremetal.harware.get_baremetals() function.
@goldyfruit goldyfruit added the enhancement New feature or request label Jul 8, 2022
Copy link
Owner

@goldyfruit goldyfruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jamesregis jamesregis merged commit 09d5868 into goldyfruit:main Jul 9, 2022
@jamesregis
Copy link
Collaborator

Thanks for your contribution 👍

@goldyfruit
Copy link
Owner

New release on PyPi.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants