This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Disabled virtualization check on Linux platforms #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change skips the virtualization check on Linux systems, always returning positive support status.
ghost
added
the
| if is_windows(): | ||
| if is_linux(): | ||
| # Virtualization support is not required to run Golem on Linux. | ||
| return True |
There was a problem hiding this comment.
Virtualization is not enabled per se, it's simply not required. I'd treat this fix as temporary. Maybe this call should be simply skipped by the UI?
There was a problem hiding this comment.
I agree, hence the comment I left there. Another option would be to change this RPC / create a new one specific to the use case (i.e. checking for Docker support).
etam
suggested changes
Mar 5, 2019
|
@shadeofblue: what's your take on this? |
|
sigh... okay @zakaprov please change the name of the function to |
Codecov Report
@@ Coverage Diff @@
## develop #3949 +/- ##
===========================================
+ Coverage 87.77% 87.81% +0.03%
===========================================
Files 216 216
Lines 18977 18979 +2
===========================================
+ Hits 16658 16666 +8
+ Misses 2319 2313 -6 |
kmazurek
added a commit
that referenced
this pull request
Mar 19, 2019
shadeofblue
added a commit
that referenced
this pull request
Mar 20, 2019
…zation Cherry pick of: Disabled virtualization check on Linux (#3949)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3937
This change skips the virtualization check on Linux systems, always returning positive support status.