This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
per task disable or lenient verification #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Comment by @shadeofblue: for integration test, instead of failing verificator, we could have a provider that always returns bogus files (for example provided 1 black pixel). |
etam
force-pushed
the
disable_verification
branch
3 times, most recently
from
7033d5e to
2cb7c6b
Compare
etam
force-pushed
the
disable_verification
branch
3 times, most recently
from
dafe51d to
087f76d
Compare
shadeofblue
reviewed
May 23, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4004 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.02%
===========================================
Files 223 223
Lines 19649 19678 +29
===========================================
+ Hits 17408 17431 +23
- Misses 2241 2247 +6 |
etam
force-pushed
the
disable_verification
branch
from
6b74b82 to
f016b57
Compare
|
I rebased changes onto latest develop and squashed some commits. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3940
Blocked by #3630
Testing plan: I think the best way to test this is to make proper integration tests. For this I need a verificator that always fails (I don't think that we could have a task that always and reliably fails verification) and an option to force using it.