This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed Hyper-V VM remaining in invalid state #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If creating the machine failed during virtual disk creation then the VM would remain in a an invalid state (actually not the VM but some config files used by docker-machine). This in turn would make it impossible to re-create the VM. The error was unsuccessfully mitigated against by adding a remove command in HyperVHypervisor._failed_to_create() method. This was not effective because removing the VM sometimes fails if it done shortly after the unsuccessful creation. To make the cleanup more robust a retry loop was added. It required changing the logic of DockerMachineHypervisor.vms() because `docker- machine remove -q` doesn't print out VMs in invalid states.
ghost
added
the
maaktweluit
approved these changes
Mar 15, 2019
Codecov Report
@@ Coverage Diff @@
## b0.19 #4012 +/- ##
==========================================
+ Coverage 89.18% 89.25% +0.06%
==========================================
Files 205 205
Lines 18414 18422 +8
==========================================
+ Hits 16423 16443 +20
+ Misses 1991 1979 -12 |
| f'machine "{name}" failed') | ||
| time.sleep(0.1) | ||
|
|
||
| else: |
There was a problem hiding this comment.
Doesn't this always trigger on the last iteration?
There was a problem hiding this comment.
That was the idea. If all the iterations passed then we assume that removing the VM failed. If it succeeded then break would be triggered and else clause wouldn't be executed.
mfranciszkiewicz
approved these changes
Mar 21, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If creating the machine failed during virtual disk creation then the VM would remain in a an invalid state (actually not the VM but some config files used by docker-machine). This in turn would make it impossible to re-create the VM.
The error had been unsuccessfully mitigated against by adding a remove command in
HyperVHypervisor._failed_to_create()method. This was not effective because removing the VM sometimes fails if it done shortly after the unsuccessful creation.To make the cleanup more robust a retry loop was added. It required changing the logic of
DockerMachineHypervisor.vms()becausedocker-machine remove -qdoesn't print out VMs in invalid states.