Message Queue Storage #4016
Message Queue Storage #4016
Conversation
ghost
assigned 
| msg_data = pw.BlobField() | ||
| created_date = pw.DateTimeField(default=datetime.datetime.now) | ||
| modified_date = pw.DateTimeField(default=datetime.datetime.now) | ||
|
|
There was a problem hiding this comment.
will messages live forever if they cannot be sent? maybe they should have some lifetime/timeout set? possibly depending on a type maybe? ... (unsure)
There was a problem hiding this comment.
I think these are removed after MESSAGE_QUEUE_MAX_AGE, see method sweep in msg_queue.py.
| ) | ||
| msg.header = msg_dt.MessageHeader( | ||
| msg.header[0], | ||
| int(time.time()), |
There was a problem hiding this comment.
are we sure that this always produces the correct unix epoch?
There was a problem hiding this comment.
Only case it didn't produce expected results was on AppVeyor. We don't use AppVeyor anymore.
| ) | ||
| continue | ||
| finally: | ||
| db_model.delete_instance() |
There was a problem hiding this comment.
hmm... what if sending of a message fails at the time it's performed? will message be returned to the queue? ... shouldn't a message be removed from the queue only after it has been successfully sent? ...
There was a problem hiding this comment.
IMHO the cost of implementing this would be higher than the benefits.
There was a problem hiding this comment.
okay, we may leave that as a future improvement if it deems necessary...
Codecov Report
@@ Coverage Diff @@
## develop #4016 +/- ##
===========================================
+ Coverage 88.6% 88.63% +0.03%
===========================================
Files 211 211
Lines 18414 18388 -26
===========================================
- Hits 16316 16299 -17
+ Misses 2098 2089 -9 |
Complete API for message queue storage.
part of #2223