This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Cleaned up typing for linter errors in taskkeeper #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
IMHO it looks more like namespace pollution than clean up to me. :) |
|
@jiivan that was based on this comment: https://github.com/golemfactory/golem/pull/4120#discussion_r275848258 Will change it according to the solution there then too :) |
maaktweluit
force-pushed
the
mwu/taskkeeper-mypy
branch
from
bf895e1 to
1beb62a
Compare
|
@jiivan updated the PR IMHO readable code is more important then a clean namespace |
mfranciszkiewicz
approved these changes
Apr 18, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4122 +/- ##
===========================================
+ Coverage 88.67% 88.68% +<.01%
===========================================
Files 214 214
Lines 18697 18697
===========================================
+ Hits 16580 16581 +1
+ Misses 2117 2116 -1 |
jiivan
approved these changes
Apr 19, 2019
|
@mfranciszkiewicz good one! did not see the typeception, will add those 2 |
maaktweluit
force-pushed
the
mwu/taskkeeper-mypy
branch
from
1beb62a to
79dcd66
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.