This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Migrate Payments to TaskPayment #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazurek
reviewed
May 30, 2019
| if self.details is None: | ||
| self.details = PaymentDetails() | ||
|
|
||
| def __repr__(self) -> str: |
There was a problem hiding this comment.
__repr__ is missing on both of the newly introduced classes, is that intentional?
There was a problem hiding this comment.
Maybe we'll add them, when they're needed?
Krigpl
suggested changes
May 30, 2019
Krigpl
suggested changes
May 31, 2019
Krigpl
suggested changes
Jun 3, 2019
Krigpl
reviewed
Jun 3, 2019
Krigpl
reviewed
Jun 3, 2019
Krigpl
reviewed
Jun 4, 2019
Krigpl
approved these changes
Jun 5, 2019
It fails in lintdiff.sh (confusion with ethereum module)
Codecov Report
@@ Coverage Diff @@
## develop #4240 +/- ##
===========================================
+ Coverage 88.56% 88.64% +0.08%
===========================================
Files 223 224 +1
Lines 19694 19643 -51
===========================================
- Hits 17442 17413 -29
+ Misses 2252 2230 -22 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4197
additionally fixes: #2457