Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fixed add_payment_info return value handling #4342

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion golem/ethereum/transactionsystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def add_payment_info( # pylint: disable=too-many-arguments
task_id: str,
subtask_id: str,
value: int,
eth_address: str) -> int:
eth_address: str) -> model.TaskPayment:
if not self._payment_processor:
raise Exception('Start was not called')
return self._payment_processor.add(
Expand Down
8 changes: 5 additions & 3 deletions golem/task/taskserver.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,18 +597,20 @@ def accept_result(self, subtask_id, key_id, eth_address: str, value: int,
task_id = self.task_manager.get_task_id(subtask_id)
task = self.task_manager.tasks[task_id]

payment_processed_ts = self.client.transaction_system.add_payment_info(
task_payment = self.client.transaction_system.add_payment_info(
node_id=task.header.task_owner.key,
task_id=task.header.task_id,
subtask_id=subtask_id,
value=value,
eth_address=eth_address,
)
payment_created_ts = int(task_payment.created_date.timestamp())

if unlock_funds:
self.client.funds_locker.remove_subtask(task_id)
logger.debug('Result accepted for subtask: %s Created payment ts: %r',
subtask_id, payment_processed_ts)
return payment_processed_ts
subtask_id, payment_created_ts)
return payment_created_ts

def income_listener(self, event='default', node_id=None, **kwargs):
if event == 'confirmed':
Expand Down
3 changes: 2 additions & 1 deletion tests/golem/task/dummy/runner.py
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
from golem.task import rpc as task_rpc
from golem.model import db, DB_FIELDS, DB_MODELS
from golem.network.transport.tcpnetwork import SocketAddress
from tests.factories import model as model_factory
from tests.golem.task.dummy.task import DummyTask, DummyTaskParameters

REQUESTING_NODE_KIND = "requestor"
Expand Down Expand Up @@ -116,7 +117,7 @@ def _make_mock_ets():
ets.eth_base_for_batch_payment.return_value = 0.001 * denoms.ether
ets.get_payment_address.return_value = '0x' + 40 * '6'
ets.get_nodes_with_overdue_payments.return_value = []
ets.add_payment_info.return_value = int(time.time())
ets.add_payment_info.return_value = model_factory.TaskPayment()
return ets


Expand Down