Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Migrate deposit payments to TaskPayment #4343

Merged
merged 8 commits into from
Jun 24, 2019
Merged

Conversation

jiivan
Copy link
Contributor

@jiivan jiivan commented Jun 14, 2019

No description provided.

@jiivan jiivan force-pushed the task_payment_deposit branch from ffa59e9 to 48ff2d8 Compare June 17, 2019 14:01
@jiivan jiivan force-pushed the task_payment_deposit branch from 48ff2d8 to 05ba8c7 Compare June 17, 2019 14:08
@jiivan jiivan requested a review from Krigpl June 17, 2019 18:38
@jiivan jiivan marked this pull request as ready for review June 17, 2019 18:38
Copy link
Contributor

@Krigpl Krigpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's safe to modify existing migrations.

@jiivan
Copy link
Contributor Author

jiivan commented Jun 18, 2019

I don't think it's safe to modify existing migrations.

I also think so, but unfortunatelly they used custom fields.

Copy link
Contributor

@Krigpl Krigpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waffle

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #4343 into develop will decrease coverage by 0.02%.
The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           develop    #4343      +/-   ##
===========================================
- Coverage    88.76%   88.73%   -0.03%     
===========================================
  Files          225      225              
  Lines        19753    19736      -17     
===========================================
- Hits         17534    17513      -21     
- Misses        2219     2223       +4

@jiivan jiivan merged commit f68a48c into develop Jun 24, 2019
@jiivan jiivan deleted the task_payment_deposit branch June 24, 2019 07:34
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants