This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
* reduce severity of mask mismatch #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor `taskkeeper.check_support` tests :p
shadeofblue
force-pushed
the
0.20-reduce-severity-of-mask-mismatch
branch
from
f434572 to
7b6dec0
Compare
jiivan
approved these changes
Jun 18, 2019
tests/golem/task/test_taskkeeper.py
Outdated
| environments_manager=EnvironmentsManager(), | ||
| node=dt_p2p_factory.Node(), | ||
| min_price=10.0) | ||
| self.assertIsInstance(tk, TaskHeaderKeeper) |
There was a problem hiding this comment.
ugh ... that's not my code ;)
Codecov Report
@@ Coverage Diff @@
## b0.20 #4360 +/- ##
==========================================
- Coverage 88.73% 88.69% -0.05%
==========================================
Files 223 223
Lines 19754 19762 +8
==========================================
- Hits 17529 17528 -1
- Misses 2225 2234 +9 |
|
|
||
|
|
||
| class TestTaskHeaderKeeper(LogTestCase): | ||
| def test_init(self): |
There was a problem hiding this comment.
This test is redundant :)
There was a problem hiding this comment.
repeat after me: it's not my code ...
| @property | ||
| def err_reason(self): | ||
| try: | ||
| return list(self.desc.keys())[0] |
There was a problem hiding this comment.
Suggested change
| return list(self.desc.keys())[0] | |
| return next(iter(self.desc)) |
You'd need to catch a StopIteration exception though.
mfranciszkiewicz
approved these changes
Jun 18, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taskkeeper.check_supporttests :pcloses: https://github.com/golemfactory/golem/issues/3438