Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Moved requesting tasks out of TaskComputer to TaskServer #4389

Merged
merged 3 commits into from
Jun 27, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Jun 26, 2019

No description provided.

@Wiezzel Wiezzel marked this pull request as ready for review June 26, 2019 13:59
@Wiezzel Wiezzel self-assigned this Jun 26, 2019
@Wiezzel Wiezzel requested review from Krigpl and maaktweluit June 26, 2019 13:59
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One small comment, will approve on reply or fix

@Wiezzel Wiezzel requested a review from maaktweluit June 27, 2019 13:23
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #4389 into develop will increase coverage by <.01%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop    #4389      +/-   ##
===========================================
+ Coverage    88.49%   88.49%   +<.01%     
===========================================
  Files          225      225              
  Lines        19845    19839       -6     
===========================================
- Hits         17561    17557       -4     
+ Misses        2284     2282       -2

@Wiezzel Wiezzel merged commit 2375a7c into develop Jun 27, 2019
@Wiezzel Wiezzel deleted the taskcomputer_refactor branch June 27, 2019 14:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants