This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Paginated RPC pay.operations #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiivan
force-pushed
the
task_payment_rpc
branch
2 times, most recently
from
8ce3b4d to
7c23c3c
Compare
etam
approved these changes
Jul 4, 2019
| @@ -484,6 +485,8 @@ def add_payment(self, processed_ts: int): | |||
| wallet_operation__direction= # noqa | |||
| model.WalletOperation.DIRECTION.outgoing, | |||
| created_date=timestamp_to_datetime(processed_ts), | |||
| wallet_operation__status= # noqa | |||
| model.WalletOperation.STATUS.awaiting, | |||
There was a problem hiding this comment.
this could be a one line, like above
There was a problem hiding this comment.
(I mean in previous change, in line 66)
Codecov Report
@@ Coverage Diff @@
## develop #4394 +/- ##
===========================================
- Coverage 88.42% 86.74% -1.68%
===========================================
Files 224 224
Lines 19841 19826 -15
===========================================
- Hits 17544 17199 -345
- Misses 2297 2627 +330 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4172
Fixes: #2402
Fixes: #3971