This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
DockerCPUConfig Allow multiple work_dirs #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
changed the title
maaktweluit
force-pushed
the
mwu/list-work-dirs
branch
2 times, most recently
from
dd611e7 to
48248c0
Compare
mfranciszkiewicz
previously approved these changes
Jul 2, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4413 +/- ##
===========================================
- Coverage 88.42% 88.42% -0.01%
===========================================
Files 224 224
Lines 19841 19862 +21
===========================================
+ Hits 17544 17562 +18
- Misses 2297 2300 +3 |
maaktweluit
force-pushed
the
mwu/list-work-dirs
branch
2 times, most recently
from
d1c5d31 to
6339ef5
Compare
maaktweluit
changed the title
|
@Wiezzel @mfranciszkiewicz ready for review! |
Wiezzel
reviewed
Jul 3, 2019
maaktweluit
force-pushed
the
mwu/list-work-dirs
branch
from
9f1657a to
785ba62
Compare
|
@Wiezzel thanks for the review, applied all the comments and rebased to clean the branch |
Co-Authored-By: Adam Wierzbicki <awierzbicki@golem.network>
maaktweluit
force-pushed
the
mwu/list-work-dirs
branch
2 times, most recently
from
e3fc03e to
c2ea07b
Compare
Co-Authored-By: Adam Wierzbicki <awierzbicki@golem.network>
maaktweluit
force-pushed
the
mwu/list-work-dirs
branch
from
c2ea07b to
9f066c7
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to allow provider and requestor side of the environment to use seperate work_dirs