This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Start UPnP discovery and mapping in a separate thread #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
approved these changes
Jul 25, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4537 +/- ##
===========================================
- Coverage 90.21% 90.18% -0.03%
===========================================
Files 223 223
Lines 19541 19543 +2
===========================================
- Hits 17628 17624 -4
- Misses 1913 1919 +6 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPnP port mapping process will no longer block the main thread.
This should improve the situation with sporadic RPC's websocket ping timeouts during startup.