This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Start tcpserver inactive, so no pause is needed after init #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4700 +/- ##
===========================================
- Coverage 90.23% 88.79% -1.44%
===========================================
Files 211 210 -1
Lines 19628 19540 -88
===========================================
- Hits 17711 17351 -360
- Misses 1917 2189 +272 |
Codecov Report
@@ Coverage Diff @@
## develop #4700 +/- ##
===========================================
- Coverage 90.23% 90.23% -0.01%
===========================================
Files 211 210 -1
Lines 19628 19540 -88
===========================================
- Hits 17711 17631 -80
+ Misses 1917 1909 -8 |
mfranciszkiewicz
approved these changes
Sep 9, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pause was only called during startup so it would deactivate the TCPServer, removed the pause and start it as
Active = False