This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Charged from deposit #4708
Merged
Charged from deposit #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krigpl
reviewed
Sep 10, 2019
|
|
||
|
|
||
| class SentForcedSubtaskPaymentTest(ForcedPaymentBase): | ||
| def test_not_in_db(self): |
There was a problem hiding this comment.
What does it check? Not a single assert in sight.
There was a problem hiding this comment.
It checks whether forced payment event with unknown payment will work. There is nothing to assert because it'll only log. I'm not a fan of log assertions.
Krigpl
approved these changes
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4708 +/- ##
===========================================
+ Coverage 90.23% 90.25% +0.01%
===========================================
Files 211 211
Lines 19630 19666 +36
===========================================
+ Hits 17714 17749 +35
- Misses 1916 1917 +1 |
mfranciszkiewicz
pushed a commit
that referenced
this pull request
Sep 16, 2019
* Charged from deposit * Bump migration after merge * [review] Move withdrawal scheduling outside concent events * [review] Typehints * [review] Use PP.add() * [review] Return early
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark transactions handled by Concent service.