Disabled logging task offers once a task is completed

golem/task/taskrequestorstats.py

@@ -42,7 +42,6 @@ def __init__(self):
     def got_want_to_compute(self):
         """Makes note of a received work offer"""
         self._want_to_compute_count += 1
-        logger.info('Received work offers: %r', self._want_to_compute_count)
 
     def got_task_message(self, msg: TaskMsg, latest_status: TaskStatus):
         """Stores information from task level message"""
@@ -408,6 +407,9 @@ def on_message(self,
             pass
 
         elif op == TaskOp.WORK_OFFER_RECEIVED:
+            if task_state.status.is_active():
+                logger.info('Received work offers: %r',
+                            self.tasks[task_id].want_to_compute_count())
             self.tasks[task_id].got_want_to_compute()
 
         elif op == TaskOp.RESTORED:

tests/golem/task/test_taskrequestorstats.py

@@ -310,7 +310,10 @@ def test_stats_collection(self):
                          "about any subtasks")
 
         # receive work offer
-        rs.on_message("task1", tstate, op=TaskOp.WORK_OFFER_RECEIVED)
+        with self.assertLogs(logger, level="INFO") as log:
+            rs.on_message("task1", tstate, op=TaskOp.WORK_OFFER_RECEIVED)
+            self.assertTrue(any("Received work offers"
+                                in line for line in log.output))
         # which does not mean that a subtask is in progress
         cs = rs.get_current_stats()
         self.assertEqual(cs, CurrentStats(1, 0, 0, 0, 0, 0, 0, 0, 1),
@@ -361,6 +364,10 @@ def test_stats_collection(self):
         self.assertTrue(rs.is_task_finished("task1"),
                         "A task should be finished now")
 
+        # we should not log on received offers once the task is finished
+        with self.assertNoLogs(logger, level="INFO"):
+            rs.on_message("task1", tstate, op=TaskOp.WORK_OFFER_RECEIVED)
+
     @staticmethod
     def create_task_and_taskstate(rs, name):
         tstate = TaskState()