This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed task timeout in RequestedTaskManager #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
commented
Oct 24, 2019
Wiezzel
commented
- Update subtask statuses
- Notify application (AbortTask)
- Shutdown application
* Update subtask statuses * Notify application (AbortTask) * Shutdown application Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
mfranciszkiewicz
approved these changes
Oct 28, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4830 +/- ##
==========================================
+ Coverage 89.2% 89.2% +<.01%
==========================================
Files 226 226
Lines 20775 20790 +15
==========================================
+ Hits 18532 18546 +14
- Misses 2243 2244 +1 |
|
@maaktweluit Bump |
maaktweluit
approved these changes
Oct 30, 2019
| task_id, self._get_computing_node() | ||
| )).subtask_id | ||
|
|
||
| # Unfortunately feezegun doesn't mock asyncio's time |
There was a problem hiding this comment.
shame, hope they solve this soon..
Maybe good to link the issue on their github?
spulec/freezegun#290
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.