Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

A different approach to TaskServer.quit #4842

Merged
merged 3 commits into from
Nov 2, 2019
Merged

A different approach to TaskServer.quit #4842

merged 3 commits into from
Nov 2, 2019

Conversation

mfranciszkiewicz
Copy link
Contributor

@mfranciszkiewicz mfranciszkiewicz commented Oct 29, 2019 •
edited
Loading

Resolves #4809

@mfranciszkiewicz
Refactor: decorate Client.stop with inlineCallbacks and yield task_se…
bbc1ed9 
…rver.quit

Refactor: decorate Client.quit with inlineCallbacks and yield self.stop
maaktweluit
maaktweluit approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its like magic, tried so many approaches to get this to work

@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (mwu/e2e-rtm@9f13aaf). Click here to learn what that means.
The diff coverage is 90%.

@@              Coverage Diff               @@
##             mwu/e2e-rtm    #4842   +/-   ##
==============================================
  Coverage               ?   89.85%           
==============================================
  Files                  ?      229           
  Lines                  ?    21022           
  Branches               ?        0           
==============================================
  Hits                   ?    18889           
  Misses                 ?     2133           
  Partials               ?        0

Wiezzel
Wiezzel approved these changes Oct 31, 2019
View reviewed changes
Copy link

@Wiezzel Wiezzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hope it works.

@mfranciszkiewicz mfranciszkiewicz merged commit dbabee6 into mwu/e2e-rtm Nov 2, 2019
@mfranciszkiewicz mfranciszkiewicz deleted the task_api_task_server_quit branch November 2, 2019 20:55
@etam etam mentioned this pull request Nov 4, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@Wiezzel Wiezzel Wiezzel approved these changes

@maaktweluit maaktweluit maaktweluit approved these changes

Assignees
No one assigned
Labels
bug clay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfranciszkiewicz @Wiezzel @maaktweluit