This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Cgi/blender 2 80 #4846
Merged
Cgi/blender 2 80 #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
reviewed
Nov 4, 2019
| @@ -206,7 +206,8 @@ def _create_subtask_info( | |||
| ctd=ComputeTaskDef( | |||
| deadline=time.time() + 3600, | |||
| docker_images=[ | |||
| DockerImage('golemfactory/blender', tag='1.9').to_dict() | |||
| DockerImage('golemfactory/blender', tag='blender_2.80') | |||
There was a problem hiding this comment.
this needs to be updated with a production tag before we merge
There was a problem hiding this comment.
Waiting for docker images updates from @nieznanysprawiciel and @zakaprov
|
@magdasta apart from the docker image, I believe the integration test scenes should be updated (I can do this if needed) and please change the base to |
shadeofblue
reviewed
Nov 12, 2019
shadeofblue
approved these changes
Nov 12, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4846 +/- ##
=========================================
- Coverage 89.2% 89.19% -0.01%
=========================================
Files 231 231
Lines 21275 21275
=========================================
- Hits 18978 18977 -1
- Misses 2297 2298 +1 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for now, Eevee is not going to be supported.