Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

adjust the expected amount after we know the actual payment value #4854

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

shadeofblue
Copy link
Contributor

@shadeofblue shadeofblue commented Nov 5, 2019

(which, in case of usage marketplace, is usually lower than the budget)

#closes gr260

@shadeofblue shadeofblue requested a review from mbenke November 5, 2019 12:43
(which, in case of usage marketplace, is usually lower than the budget)
@shadeofblue shadeofblue force-pushed the gr260-2-adjust-requestor-quality branch from 1a7284e to 9698843 Compare November 5, 2019 13:20
Copy link
Contributor

@mbenke mbenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to adjust when submitting ReportComputedTask

@shadeofblue
Copy link
Contributor Author

It might be better to adjust when submitting ReportComputedTask

indeed, added that adjustment to SRR handling because it's more explicit there and more in-line with the existing budget/payment checks

Copy link
Contributor

@mbenke mbenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #4854 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4854      +/-   ##
===========================================
+ Coverage    89.36%   89.37%   +0.01%     
===========================================
  Files          227      227              
  Lines        20811    20827      +16     
===========================================
+ Hits         18598    18615      +17     
+ Misses        2213     2212       -1

@shadeofblue shadeofblue merged commit fcbe27c into develop Nov 6, 2019
@shadeofblue shadeofblue deleted the gr260-2-adjust-requestor-quality branch November 6, 2019 09:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants