Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

don't store booleans in config_desc #4861

Merged
merged 2 commits into from
Nov 7, 2019
Merged

don't store booleans in config_desc #4861

merged 2 commits into from
Nov 7, 2019

Conversation

etam
Copy link
Contributor

@etam etam commented Nov 6, 2019

supplements #4860

@etam etam requested a review from maaktweluit November 6, 2019 14:22
@etam etam self-assigned this Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019 •
edited
Loading

Codecov Report

Merging #4861 into b0.22 will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            b0.22   #4861      +/-   ##
=========================================
+ Coverage   88.93%   89.2%   +0.27%     
=========================================
  Files         231     231              
  Lines       21267   21267              
=========================================
+ Hits        18914   18972      +58     
+ Misses       2353    2295      -58

@etam etam changed the base branch from b0.21 to b0.22 November 7, 2019 08:41
@etam
Copy link
Contributor Author

etam commented Nov 7, 2019

rebased to b0.22

@etam etam merged commit c003090 into b0.22 Nov 7, 2019
@etam etam deleted the fix_in_shutdown branch November 7, 2019 10:29
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@maaktweluit maaktweluit maaktweluit approved these changes

Assignees

@etam etam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etam @maaktweluit