This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Only include task_api apps on testnet #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
reviewed
Nov 7, 2019
|
@Wiezzel good one, will look at this tomorrow, in this PR :) Was thinking if a task is not able to be requested the provider "switch" is not needed, but it is a good practice to include it on both sides. |
Wiezzel
suggested changes
Nov 8, 2019
|
@Wiezzel saw your main comment after fixing all the others 🤦♂ Moved the logic to use envs instead, indeed much neater. |
Wiezzel
reviewed
Nov 8, 2019
maaktweluit
force-pushed
the
mwu/b0.22/task-api-mainnet-off
branch
from
241629c to
16bf9bf
Compare
Wiezzel
approved these changes
Nov 8, 2019
mfranciszkiewicz
approved these changes
Nov 8, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4871 +/- ##
==========================================
- Coverage 90.14% 89.19% -0.95%
==========================================
Files 231 231
Lines 21279 21286 +7
==========================================
- Hits 19182 18987 -195
- Misses 2097 2299 +202 |
maaktweluit
force-pushed
the
mwu/b0.22/task-api-mainnet-off
branch
from
51185fb to
703908f
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So they can be safely tested on testnet first