Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Restore task-api task timeouts after restarting node #4894

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

maaktweluit
Copy link
Contributor

Schedule or trigger the timeouts of task-api tasks when restarting the golem node

Copy link

@Wiezzel Wiezzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have two comments though:

  1. What about subtask timeouts?
  2. Some unit tests for this feature would be nice.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #4894 into b0.22 will decrease coverage by 0.96%.
The diff coverage is 89.28%.

@@            Coverage Diff            @@
##            b0.22   #4894      +/-   ##
=========================================
- Coverage   90.16%   89.2%   -0.97%     
=========================================
  Files         233     233              
  Lines       21419   21445      +26     
=========================================
- Hits        19313   19130     -183     
- Misses       2106    2315     +209

@mfranciszkiewicz mfranciszkiewicz merged commit ebc11af into b0.22 Nov 20, 2019
@mfranciszkiewicz mfranciszkiewicz deleted the mwu/restart-timeouts branch November 20, 2019 12:22
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants