This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65ca07f
to
d951738
Compare
@mfranciszkiewicz @maaktweluit Please review. It's a draft because I don't want to merge it to b0.22. Will make a proper PR once b0.22 is merged to develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. One small doubt about the stability of stream
maaktweluit
approved these changes
Nov 28, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4901 +/- ##
===========================================
- Coverage 90.07% 89.12% -0.96%
===========================================
Files 233 233
Lines 21598 21660 +62
===========================================
- Hits 19454 19304 -150
- Misses 2144 2356 +212 |
d951738
to
589ec56
Compare
a0f0e8f
to
a3dc979
Compare
Defined a set of common counters for Runtime objects. Implemented the counters for Docker environment. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Adjusted assertions for RAM and CPU. Marked tests as slow for they are such (>5s each). Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
a3dc979
to
618d57a
Compare
mfranciszkiewicz
approved these changes
Dec 3, 2019
Closed
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined a set of common counters for Runtime objects. Implemented the counters for Docker environment.
Do not merge. It's not supposed to go into 0.22 release.