This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fix: Task API 'comp.task.subtask' RPC call compatibility #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranciszkiewicz
force-pushed
the
task_api_rpc_subtask
branch
from
22e61d4 to
8df6207
Compare
maaktweluit
approved these changes
Nov 18, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4903 +/- ##
=========================================
- Coverage 90.18% 90% -0.18%
=========================================
Files 233 233
Lines 21419 21418 -1
=========================================
- Hits 19316 19278 -38
- Misses 2103 2140 +37 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
subtask_ids are unique, there is no need to extend RPC calls and identify subtasks by a(task_id, subtask_id)tuple.