-
Notifications
You must be signed in to change notification settings - Fork 284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Did not check the terms ;)
Codecov Report
@@ Coverage Diff @@
## b0.22 #4961 +/- ##
==========================================
- Coverage 90.16% 89.19% -0.97%
==========================================
Files 233 233
Lines 21773 21773
==========================================
- Hits 19631 19421 -210
- Misses 2142 2352 +210 |
golem/CONCENT_TERMS.html
Outdated
<h4><u>Terms of Use of Concent Service</u></h4> | ||
<p><em>Last Update: June 2019.</em></p> | ||
<p> | ||
These Terms of Use of Concent Service (hereinafter the “Terms of Use”) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make sure this is a simple ascii text file, not utf8. So all “
should be changed to "
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and ’
to '
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, detected by the test suite and fixed already :)
No description provided.