This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Strip newline from docker-machine ip output #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranciszkiewicz
approved these changes
Dec 6, 2019
Codecov Report
@@ Coverage Diff @@
## b0.22 #4974 +/- ##
==========================================
+ Coverage 89.22% 90.17% +0.94%
==========================================
Files 233 233
Lines 21784 21782 -2
==========================================
+ Hits 19436 19641 +205
+ Misses 2348 2141 -207 |
Docker-machine outputs a newline character at the end of command output. In case of `ip` command this results in invalid address string if the trailing newline is not stripped.
Wiezzel
force-pushed
the
fix_task_api_getaddrinfo
branch
from
085421b to
58d7f37
Compare
maaktweluit
approved these changes
Dec 6, 2019
|
@maaktweluit Nice idea but we don't have much time now so I'm merging it as is. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-machine outputs a newline character at the end of command output. In case of
ipcommand this results in invalid address string if the trailing newline is not stripped.